Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable intraprocess for transient local topics #193

Open
wants to merge 1 commit into
base: ros2
Choose a base branch
from

Conversation

Aposhian
Copy link

@Aposhian Aposhian commented Aug 16, 2023

Related Issues & PRs

Summary of Changes

Explicitly disable intraprocess communication for metadata publisher and subscription, otherwise it fails if you try to set use_intraprocess_comms: True on the whole node.

Validation

In progress.

@Samahu Samahu self-requested a review August 21, 2023 19:59
@Samahu
Copy link
Contributor

Samahu commented Aug 21, 2023

@Aposhian is this ready? Do you plan on providing validation steps?

@Aposhian
Copy link
Author

I have tested this and it works. I will provide a test to replicate shortly

@Aposhian
Copy link
Author

Ok here are the validation steps to reproduce the bug and how this PR fixes it:

To reproduce:

You get this error:

[component_container_mt-2] [ERROR] [1692982283.515302684] [ouster.os_container]: Component constructor threw an exception: intraprocess communication allowed only with volatile durability

But after applying this fix by merging this PR in like on this branch https://github.com/fireflyautomatix/ouster-ros/tree/example/intraprocess-comms-fixed, the error doesn't show up anymore.

@Samahu
Copy link
Contributor

Samahu commented Aug 31, 2023

@Aposhian Which rosdistro do you test against? I couldn't generate the problem under rolling.

@Aposhian
Copy link
Author

Humble. I believe there is addressed in rolling.

@Samahu
Copy link
Contributor

Samahu commented Aug 31, 2023

🤔 then I need to create a branch for humble similar to having a foxy branch and merge the pull request into it. Let me get that ready and will get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants